-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add fetch instructions to README #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It took me a little while to figure out, even though it's not simple, so I thought it would be a good addition to the docs
Something like this is what you'd prefer?
I hate those variable names, but dropping the |
tbh I kind of prefer the non-promised version because the user is probably constructing the SQL object somewhere besides right where they're fetching the data? It's only there for reference really, and a user can make it more efficient if they want? |
But of course it's your repo! So whatever makes sense to you wfm |
This looks good to me. Just drop the extra indentation.
Yes, they will probably have the creation of |
works for me, will update it |
per discussion on #436
Thanks! |
* add fetch instructions to README It took me a little while to figure out, even though it's not simple, so I thought it would be a good addition to the docs * use promise.all instead of sequential awaits per discussion on sql-js/sql.js#436
* add fetch instructions to README It took me a little while to figure out, even though it's not simple, so I thought it would be a good addition to the docs * use promise.all instead of sequential awaits per discussion on sql-js/sql.js#436
It took me a little while to figure out, even though it's simple, so I thought it would be a good addition to the docs